[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-doc
Subject:    Re: [PATCH 1/3] Documentation-getdelays: Fix a check for container file usage in main()
From:       Jonathan Corbet <corbet () lwn ! net>
Date:       2015-12-24 14:22:10
Message-ID: 20151224072210.15d6ee6c () lwn ! net
[Download RAW message or body]

On Thu, 24 Dec 2015 13:34:20 +0100
SF Markus Elfring <elfring@users.sourceforge.net> wrote:

> The close() function could be called by the main() function even if
> the passed variable "cfd" was assigned a negative value.
> 
> * Corresponding implementation details could be improved by adjustments
>   for jump targets according to the Linux coding style convention.
> 
> * Fix the affected condition check.

This seems more easily fixed by simply making the condition > 0.
Meanwhile, I'd really not add labels-inside-if-statements as an example
in the documentation tree.

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]