[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-crypto-vger
Subject: Re: [PATCH] crypto: DRBG - switch to HMAC SHA512 DRBG as default DRBG
From: Stephan Mueller <smueller () chronox ! de>
Date: 2021-06-24 14:54:16
Message-ID: 7a7f5523271ffe9784cfc98cf28e474ca5507e6c.camel () chronox ! de
[Download RAW message or body]
Am Donnerstag, dem 24.06.2021 um 22:30 +0800 schrieb Herbert Xu:
> On Thu, May 20, 2021 at 09:31:11PM +0200, Stephan Müller wrote:
> >
> > diff --git a/crypto/drbg.c b/crypto/drbg.c
> > index 1b4587e0ddad..ea85d4a0fe9e 100644
> > --- a/crypto/drbg.c
> > +++ b/crypto/drbg.c
> > @@ -176,18 +176,18 @@ static const struct drbg_core drbg_cores[] = {
> > .blocklen_bytes = 48,
> > .cra_name = "hmac_sha384",
> > .backend_cra_name = "hmac(sha384)",
> > - }, {
> > - .flags = DRBG_HMAC | DRBG_STRENGTH256,
> > - .statelen = 64, /* block length of cipher */
> > - .blocklen_bytes = 64,
> > - .cra_name = "hmac_sha512",
> > - .backend_cra_name = "hmac(sha512)",
> > }, {
> > .flags = DRBG_HMAC | DRBG_STRENGTH256,
> > .statelen = 32, /* block length of cipher */
> > .blocklen_bytes = 32,
> > .cra_name = "hmac_sha256",
> > .backend_cra_name = "hmac(sha256)",
> > + }, {
> > + .flags = DRBG_HMAC | DRBG_STRENGTH256,
> > + .statelen = 64, /* block length of cipher */
> > + .blocklen_bytes = 64,
> > + .cra_name = "hmac_sha512",
> > + .backend_cra_name = "hmac(sha512)",
> > },
>
> Hi Stephan:
>
> I just noticed that unlike hmac(sha256) drbg with hmac(sha512)
> doesn't have a self-test. Could you add one for it please?
Thank you very much for pointing this out. I will prepare one asap.
Thanks
Stephan
>
> Thanks,
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic