[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-crypto-vger
Subject:    Re: [PATCH] crypto/xor.c: use 2 pages for xor speed testing
From:       Marek Vasut <marex () denx ! de>
Date:       2014-06-25 19:59:18
Message-ID: 201406252159.18622.marex () denx ! de
[Download RAW message or body]

On Tuesday, June 17, 2014 at 09:16:03 AM, Amos Kong wrote:
[...]
> > While looking at this code, can anyone explain to me why we have this
> > stuff in crypto/xor.c please ?
> > 
> > 135 #define xor_speed(templ)        do_xor_speed((templ), b1, b2)
> > 136
> > 137         if (fastest) {
> > 138                 printk(KERN_INFO "xor: automatically using best "
> > 139                                  "checksumming function:\n");
> > 140                 xor_speed(fastest);
> > 141                 goto out;
> > 142         } else {
> > [...]
> > 149         }
> > 150
> > 151         printk(KERN_INFO "xor: using function: %s (%d.%03d
> > MB/sec)\n", 152                fastest->name, fastest->speed / 1000,
> > fastest->speed % 1000); 153
> > 154 #undef xor_speed
> > 
> > Why do we not call do_xor_speed(fastest, b1, b2); right away , but we
> > #define xor_speed() instead ? This looks like some remnant or nonsense
> > to me. Shall I remove that with a patch ?
> 
> You are right.

I'm wrong. The XOR_TRY_TEMPLATES needs this #define xor_speed , so there's no 
patch happening here. Sorry.

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]