[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-crypto-vger
Subject:    Re: [PATCH] sparc64: Add CRC32C driver making use of the new crc32c opcode.
From:       David Miller <davem () davemloft ! net>
Date:       2012-08-23 16:20:43
Message-ID: 20120823.092043.1156875617277157051.davem () davemloft ! net
[Download RAW message or body]

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 23 Aug 2012 16:36:54 +0800

> On Wed, Aug 22, 2012 at 08:52:31PM -0700, David Miller wrote:
>> 
>> Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> Looks good to me.

Thanks for reviewing.

>> This was largely straightforward, except for two things.
>> 
>> 1) The tests assume that the 32-bit crc is stored in the context in
>>    cpu endian.  The sparc64 crc32c opcode wants to work with a little
>>    endian mode, but sparc64 is big-endian.
> 
> We can still change this as nothing outside the kernel relies
> on the format of the context.  For the time being all that's
> required is that it be identical between software and hardware
> implementations.

Ok, let's just leave it alone for now :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]