[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-crypto-vger
Subject:    Re: PATCH crypto/zlib: Allow Z_OK return value from zlib_deflate
From:       Herbert Xu <herbert () gondor ! apana ! org ! au>
Date:       2009-12-23 12:01:57
Message-ID: 20091223120157.GA29795 () gondor ! apana ! org ! au
[Download RAW message or body]

On Sun, Dec 20, 2009 at 02:34:09PM -0500, Aseem Rastogi wrote:
> From: Aseem Rastogi
> 
> crypto/zlib: When zlib_deflate is called with Z_FINISH flag, it should be
> considered valid if it returns Z_OK instead of Z_STREAM_END.
> 
> zlib_defalte allows callers to call it with Z_FINISH flag multiple times. This
> is useful if output buffer did not have enough space first time zlib_deflate
> was called with Z_FINISH set. zlib_deflate returns Z_OK in that case and
> expects that caller will invoke it again with Z_FINISH set to collect
> remaining data. So, return value from zlib_deflate can be Z_OK OR
> Z_STREAM_END. zlib_compress_final is modified to allow return value of Z_OK.
> 
> Signed-off-by: Aseem Rastogi <arastogi@cs.sunysb.edu>
> Tested-by: Aseem Rastogi <arastogi@cs.sunysb.edu>
> Reviewed-by: Vasily Tarasov <vtaras@cs.sunysb.edu>

Hmm, it seems that the semantics of the final function isn't
quite right.  It was never meant to be called multiple times.

Let me see if we can fix this up without touching the interface.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]