[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-cifs-client
Subject:    Re: [linux-cifs-client] [PATCH] cifs: Fix incorrect return code
From:       Christoph Hellwig <hch () infradead ! org>
Date:       2009-06-25 15:50:11
Message-ID: 20090625155011.GA15140 () infradead ! org
[Download RAW message or body]

On Thu, Jun 25, 2009 at 06:12:34PM +0530, Suresh Jayaraman wrote:
> 
> FreeXid() along with freeing Xid does add a cifsFYI debug message that
> prints rc (return code) as well. In some code paths where we set/return
> error code after calling FreeXid(), incorrect error code is being
> printed when cifsFYI is enabled.
> 
> This could be misleading in few cases. For eg.
> In cifs_open() if cifs_fill_filedata() returns a valid pointer to
> cifsFileInfo, FreeXid() prints rc=-13 whereas 0 is actually being
> returned. Fix this by setting rc before calling FreeXid().
> 
> Basically convert

I'd say just kill the xid crap instead of adding cumbersome workarounds
due to the awkward way they are defined.

_______________________________________________
linux-cifs-client mailing list
linux-cifs-client@lists.samba.org
https://lists.samba.org/mailman/listinfo/linux-cifs-client
[prev in list] [next in list] [prev in thread] [next in thread]