[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-cifs-client
Subject:    Re: [linux-cifs-client] [PATCH 4/5] [CIFS] have CIFSSMBNegotiate
From:       Jeff Layton <jlayton () redhat ! com>
Date:       2007-10-30 16:57:10
Message-ID: 20071030125710.517df818 () tleilax ! poochiereds ! net
[Download RAW message or body]

On Tue, 30 Oct 2007 19:48:30 +0300
"Q (Igor Mammedov)" <qwerty0987654321@mail.ru> wrote:

> Jeff Layton wrote:
> > I just realized that this patch has a significant (and rather
> > boneheaded) bug. If we call cifs_setup_session on a reconnect, then
> > we'll end up calling CIFS_SessSetup with a NULL spnego_key. I'm
> > still looking at the right way to fix it, but anyone testing this
> > should be aware of this. I'll repost once I have a solution and
> > have tested it.
> 
> Then you could consider abandoning CIFSSMBNegotiate and moving to 
> CIFS_SessSetup for handling SPNEGO stuff. That will simplify your
> patch: make a change in one place instead of many.
> 
> PS:
>   And it will look more like mine patch :) (in the end).
> 
> 

Yep. That's exactly what I think I'm going to do. I want to look over
this a bit more closely first and also run it by Simo. He had strong
objections to doing the ASN.1 parsing in-kernel, but I'm starting to
think that we need to at least do some of it there.

-- 
Jeff Layton <jlayton@redhat.com>
_______________________________________________
linux-cifs-client mailing list
linux-cifs-client@lists.samba.org
https://lists.samba.org/mailman/listinfo/linux-cifs-client
[prev in list] [next in list] [prev in thread] [next in thread]