[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-cifs
Subject:    Re: [PATCH] cifs: fix tcon leak in cifs_atomic_open error path
From:       David Disseldorp <ddiss () suse ! de>
Date:       2017-10-30 0:14:19
Message-ID: 20171030011419.272af60e () suse ! de
[Download RAW message or body]

On Mon, 30 Oct 2017 10:57:11 +1100, Ronnie Sahlberg wrote:

> Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
> ---
>  fs/cifs/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
> index 513ff2986c97..81ba6e0d88d8 100644
> --- a/fs/cifs/dir.c
> +++ b/fs/cifs/dir.c
> @@ -521,7 +521,7 @@ cifs_atomic_open(struct inode *inode, struct dentry *direntry,
>  
>  	rc = check_name(direntry, tcon);
>  	if (rc)
> -		goto out_free_xid;
> +		goto out;
>  
>  	server = tcon->ses->server;

Looks good.
Reviewed-by: David Disseldorp <ddiss@samba.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]