[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-cifs
Subject:    Re: [PATCH v2 1/3] generic/013: encapsulate remount during cleanup
From:       Pavel Shilovsky <piastryyy () gmail ! com>
Date:       2014-08-28 18:50:36
Message-ID: 5F4BB2B2-2286-4EC0-B70C-F5BC107DA513 () gmail ! com
[Download RAW message or body]



>> 28 ΑΧΗ. 2014 Η., Χ 21:08, Christoph Hellwig <hch@infradead.org> ΞΑΠΙΣΑΜ(Α):
>> 
>> On Wed, Aug 27, 2014 at 12:28:36AM +0400, Pavel Shilovsky wrote:
>> The existing code calls remount for $TEST_DEV with constantly defined
>> mount options. This can fail if a user specifies different mount options.
>> Fix this by using new _test_remount() call that remounts $TEST_DEV.
> 
> Looks technically correct, but I still wonder why it's needed at all,
> I can't see anything in the test that would remount the filesystem
> read-only.  git history isn't a help here as the remount goes back to
> the first public revision.

Anyway I think it won't hurt to apply this patch at first and then probably remove this part at all.

--
Best regards,
Pavel Shilovsky.--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]