[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-cifs
Subject: Re: [patch] cifs: writing past end of struct in cifs_convert_address()
From: Jeff Layton <jlayton () redhat ! com>
Date: 2012-03-29 19:57:57
Message-ID: 20120329155757.4f44a3ad () corrin ! poochiereds ! net
[Download RAW message or body]
On Thu, 1 Mar 2012 10:06:52 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> "s6->sin6_scope_id" is an int bits but strict_strtoul() writes a long
> so this can corrupt memory on 64 bit systems.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
> index 73e47e8..cab99b5 100644
> --- a/fs/cifs/netmisc.c
> +++ b/fs/cifs/netmisc.c
> @@ -197,8 +197,7 @@ cifs_convert_address(struct sockaddr *dst, const char *src, int len)
> memcpy(scope_id, pct + 1, slen);
> scope_id[slen] = '\0';
>
> - rc = strict_strtoul(scope_id, 0,
> - (unsigned long *)&s6->sin6_scope_id);
> + rc = kstrtouint(scope_id, 0, &s6->sin6_scope_id);
> rc = (rc == 0) ? 1 : 0;
> }
>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic