[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-cgroups
Subject:    Re: [PATCH 1/2] mm, memcontrol: Add memcg_iterate_all()
From:       Michal Hocko <mhocko () kernel ! org>
Date:       2019-06-28 7:10:49
Message-ID: 20190628071049.GA2751 () dhcp22 ! suse ! cz
[Download RAW message or body]

On Thu 27-06-19 17:03:06, Waiman Long wrote:
> On 6/27/19 11:07 AM, Michal Hocko wrote:
> > On Mon 24-06-19 13:42:18, Waiman Long wrote:
> >> Add a memcg_iterate_all() function for iterating all the available
> >> memory cgroups and call the given callback function for each of the
> >> memory cgruops.
> > Why is a trivial wrapper any better than open coded usage of the
> > iterator?
> 
> Because the iterator is only defined within memcontrol.c. So an
> alternative may be to put the iterator into a header file that can be
> used by others. Will take a look at that.

That would be preferred.

Thanks!
-- 
Michal Hocko
SUSE Labs
[prev in list] [next in list] [prev in thread] [next in thread]