[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-can
Subject:    Re: [PATCH] can: flexcan: flexcan_error_irq_disable(): add missing variable initialization
From:       Angelo Dureghello <angelo () kernel-space ! org>
Date:       2021-07-28 8:02:51
Message-ID: 0df3a8b6-7fa5-c68b-8c4f-10baca48c01b () kernel-space ! org
[Download RAW message or body]

Hi,

thanks for the fix,


On 28/07/21 9:56 AM, Marc Kleine-Budde wrote:
> The subject is obviously wrong, fixed to "flexcan_clks_enable()".
> 
> Marc
> 
> On 28.07.2021 09:54:28, Marc Kleine-Budde wrote:
>> This patch adds the missing initialization of the "err" variable in
>> the flexcan_clks_enable() function.
>>
>> Fixes: d9cead75b1c6 ("can: flexcan: add mcf5441x support")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Cc: Angelo Dureghello <angelo@kernel-space.org>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>>   drivers/net/can/flexcan.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
>> index 54ffb796a320..7734229aa078 100644
>> --- a/drivers/net/can/flexcan.c
>> +++ b/drivers/net/can/flexcan.c
>> @@ -649,7 +649,7 @@ static inline void flexcan_error_irq_disable(const struct flexcan_priv *priv)
>>   
>>   static int flexcan_clks_enable(const struct flexcan_priv *priv)
>>   {
>> -	int err;
>> +	int err = 0;
>>   
>>   	if (priv->clk_ipg) {
>>   		err = clk_prepare_enable(priv->clk_ipg);
>> -- 
>> 2.30.2
>>
>>
>>
> 

regards,
-- 
Angelo Dureghello
[prev in list] [next in list] [prev in thread] [next in thread]