[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-can
Subject:    [net 5/5] can: kvaser_pciefd: kvaser_pciefd_open(): fix error handling
From:       Marc Kleine-Budde <mkl () pengutronix ! de>
Date:       2020-11-30 12:53:07
Message-ID: 20201130125307.218258-6-mkl () pengutronix ! de
[Download RAW message or body]

From: Zhang Qilong <zhangqilong3@huawei.com>

If kvaser_pciefd_bus_on() failed, we should call close_candev() to avoid
reference leak.

Fixes: 26ad340e582d3 ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201128133922.3276973-3-zhangqilong3@huawei.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/net/can/kvaser_pciefd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c
index 72acd1ba162d..43151dd6cb1c 100644
--- a/drivers/net/can/kvaser_pciefd.c
+++ b/drivers/net/can/kvaser_pciefd.c
@@ -692,8 +692,10 @@ static int kvaser_pciefd_open(struct net_device *netdev)
 		return err;
 
 	err = kvaser_pciefd_bus_on(can);
-	if (err)
+	if (err) {
+		close_candev(netdev);
 		return err;
+	}
 
 	return 0;
 }
-- 
2.29.2


[prev in list] [next in list] [prev in thread] [next in thread]