[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-can
Subject:    Re: plx_pci.c patch
From:       Oliver Hartkopp <socketcan () hartkopp ! net>
Date:       2013-12-27 15:21:08
Message-ID: 52BD9AE4.7010104 () hartkopp ! net
[Download RAW message or body]

Hello Oleg,

thanks for your contribution!

On 23.12.2013 20:10, Олег Мороз wrote:
> 
> Hello. I've added the ELCUS CAN-200-PCI card support into sja1000_plx_pci
> driver. Could you please review my changes and commit it to the  Linux kernel
> repository?
> 

Please post patches always in-line, e.g. an example for plx_pci.c is this
commit:

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/net/can/sja1000/plx_pci.c?id=e4bc6c06569a90512169d98a11b3eb2ec18da4ae


Which had this patch:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/drivers/net/can/sja1000/plx_pci.c?id=e08534b57e79fa722e3136b79868a725a8eea0f0


And this post on the mailing list:
http://marc.info/?l=linux-netdev&m=132368716608087&w=2

Please sent your patch the same way with a proper Signed-off-by: statement
(preferably without cyrillic characters).

Please clean up your code changes before => remove the line changes below!

Best regards,
Oliver 


@@ -440,13 +462,14 @@ static void plx_pci_reset_marathon(struc
 	}
 }
 
+
+

(why did you introduce these lines?)

 static void plx_pci_del_card(struct pci_dev *pdev)
 {
 	struct plx_pci_card *card = pci_get_drvdata(pdev);
 	struct net_device *dev;
 	struct sja1000_priv *priv;
 	int i = 0;
-

(there should remain an empty line)
 
 	for (i = 0; i < PLX_PCI_MAX_CHAN; i++) {
 		dev = card->net_dev[i];
 		if (!dev)

=> please leave this code as-is. Tnx.

ps. For the entire correct process see:
https://www.kernel.org/doc/Documentation/SubmittingPatches
--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]