[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-can
Subject:    Re: [PATCH v2] can: sja1000: fix endian on arm
From:       Christoph Fritz <chf.fritz () googlemail ! com>
Date:       2013-04-11 18:53:33
Message-ID: 1365706413.4136.15.camel () mars
[Download RAW message or body]

On Thu, 2013-04-11 at 20:47 +0200, Marc Kleine-Budde wrote:
> On 04/11/2013 08:44 PM, Christoph Fritz wrote:
> > To get correct endian on arm cpus while reading device tree properties,
> > this patch replaces of_get_property() with of_property_read_u32().
> > 
> > Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> 
> looks good, one nitpick inline
> 
> > ---
> > drivers/net/can/sja1000/sja1000_of_platform.c |   32 ++++++++++++-------------
> > 1 file changed, 16 insertions(+), 16 deletions(-)
> > 
> > diff --git a/drivers/net/can/sja1000/sja1000_of_platform.c \
> > b/drivers/net/can/sja1000/sja1000_of_platform.c

> > @@ -168,8 +168,8 @@ static int sja1000_ofp_probe(struct platform_device *ofdev)
> > 		priv->cdr |= CDR_CLK_OFF; /* default */
> > 	}
> > 
> > -	prop = of_get_property(np, "nxp,no-comparator-bypass", NULL);
> > -	if (!prop)
> > +	err = of_property_read_u32(np, "nxp,no-comparator-bypass", &prop);
> 
> What about using of_property_read_bool instead?

 Yeah, that would be better, thanks - let me re-roll this.



--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]