[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-can
Subject:    Re: [PATCH] candump: add option to ignore ENOBUFS
From:       Yegor Yefremov <yegorslists () googlemail ! com>
Date:       2012-10-29 8:00:11
Message-ID: CAGm1_kvSeE3ge9SJB7Vb=J1e8qR_92aAAkRghe88M-_ErBEEBg () mail ! gmail ! com
[Download RAW message or body]

On Sun, Oct 28, 2012 at 9:02 PM, Oliver Hartkopp <socketcan@hartkopp.net> wrote:
> On 26.10.2012 11:46, Marc Kleine-Budde wrote:
>
>> On 10/26/2012 11:42 AM, yegorslists@googlemail.com wrote:
>>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>>
>>> -f option replicated -i option from cangen and allows to
>>> ignore ENOBUFS error in bridge mode
>>
>> Better not ignore, but handle the error. If socket would support, wait
>> with select/poll that the socket get writable and try again. For now
>> sleep and try again. (or fix the poll/select bug in the kernel).
>
>
> ACK.
>
> IIRC this was a problem of socket write queue length that are too long to
> handle short MTUs like we have with CAN frames.
> Therefore the socket itself does not stop the traffic.
>
> Definitely something to be fixed ... i'll take a look into the mails from
> Michal Sojka.

Thanks. So the whole changes then would be related to all can-utils,
that can send data (candump, cangen etc.)?

Yegor
--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]