[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-btrfs
Subject:    Re: [PATCH v2] btrfs: zoned: do not enable async discard
From:       Damien Le Moal <dlemoal () kernel ! org>
Date:       2023-06-30 0:00:05
Message-ID: 2498b51e-5aed-348e-8c87-a62482a1fbae () kernel ! org
[Download RAW message or body]

On 6/29/23 20:25, Roman Mamedov wrote:
> On Thu, 29 Jun 2023 18:15:05 +0900
> Damien Le Moal <dlemoal@kernel.org> wrote:
> 
>>> +	if (btrfs_test_opt(info, DISCARD_ASYNC)) {
>>> +		btrfs_warn(info, "zoned: disabling async discard as it is not supported");
>>
>> The "not supported" mention here kind of imply that we are not finished with
>> this support yet. So may be a simple: "zoned: ignoring async discard" would
>> suffice ?
> 
> IMO "not supported" does not imply "not supported yet". To me the message
> reads more like "not supported by definition" (of zoned), i.e. no
> misunderstanding.

Yeah... I guess it can be understood both ways. I generally prefer to not
"scare" (again, that is very subjective) the user with messages saying "not
supported" if in fact it is not about support but about the feature not being
needed or not appropriate for the setup. But no strong feeling about all this.
Let's keep the message as is. My RB tag stands.

-- 
Damien Le Moal
Western Digital Research

[prev in list] [next in list] [prev in thread] [next in thread]