[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-bridge
Subject:    Re: [Bridge] [PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag
From:       Florian Fainelli <f.fainelli () gmail ! com>
Date:       2021-02-12 18:07:14
Message-ID: 6097810e-9b74-df81-ccc4-3a4b47b94b67 () gmail ! com
[Download RAW message or body]



On 2/12/2021 7:15 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> For the netlink interface, propagate errors through extack rather than
> simply printing them to the console. For the sysfs interface, we still
> print to the console, but at least that's one layer higher than in
> switchdev, which also allows us to silently ignore the offloading of
> flags if that is ever needed in the future.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

I suppose the slight "loss" of information on which port failed the
operation is okay since it was implied by either the path (sysfs) or the
bridge command.
-- 
Florian
[prev in list] [next in list] [prev in thread] [next in thread]