[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-bridge
Subject:    Re: [Bridge] [PATCH net v3] net: bridge: Fix ethernet header pointer before check skb forwardable
From:       wangyunjian <wangyunjian () huawei ! com>
Date:       2019-01-17 1:40:51
Message-ID: 34EFBCA9F01B0748BEB6B629CE643AE60C9DDABB () DGGEMM533-MBX ! china ! huawei ! com
[Download RAW message or body]

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, January 17, 2019 1:33 AM
> To: wangyunjian <wangyunjian@huawei.com>
> Cc: netdev@vger.kernel.org; xudingke <xudingke@huawei.com>;
> bridge@lists.linux-foundation.org; Nkolay Aleksandrov
> <nikolay@cumulusnetworks.com>; Roopa Prabhu
> <roopa@cumulusnetworks.com>
> Subject: Re: [PATCH net v3] net: bridge: Fix ethernet header pointer before
> check skb forwardable
> 
> On Wed, 16 Jan 2019 21:04:21 +0800
> wangyunjian <wangyunjian@huawei.com> wrote:
> 
> >  		if (unlikely(netpoll_tx_running(to->br->dev))) {
> > +			skb_push(skb, ETH_HLEN);
> >  			if (!is_skb_forwardable(skb->dev, skb)) {
> >  				kfree_skb(skb);
> >  			} else {
> > -				skb_push(skb, ETH_HLEN);
> >  				br_netpoll_send_skb(to, skb);
> >  			}
> >  			return;
> 
> The patch looks correct.
> 
> On minor style issue is that after moving skb_push out of the if statement,
> both branches of the statement now contain a single line and therefore the
> brackets are no longer necessary.  Suprised that checkpatch did not complain
> about this.

OK, I'll fix it and send the v4 later.

Thanks
	Yunjian

[prev in list] [next in list] [prev in thread] [next in thread]