[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-bridge
Subject:    Re: [Bridge] [PATCH net v2 2/2] bridge: netlink: register netdevice before executing changelink
From:       Stephen Hemminger <stephen () networkplumber ! org>
Date:       2017-04-08 13:32:44
Message-ID: 20170408093244.593a8624 () plumbers-lap ! home ! lan
[Download RAW message or body]

On Sat, 8 Apr 2017 14:41:59 +0300
<idosch@mellanox.com> wrote:

> +	err = br_changelink(dev, tb, data);
> +	if (err)
> +		goto unregister;
> +
> +	return 0;
> +
> +unregister:
> +	unregister_netdevice(dev);
> +	return err;
>  }

Why use a goto? just do:
	err = br_changelink(dev, tb, data);
	if (err)
		unregister_netdevice(dev)
	return err;
}


The goto looks ugly
[prev in list] [next in list] [prev in thread] [next in thread]