[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-bridge
Subject:    Re: [Bridge] [PATCHv2] bridge: disable snooping if there is no querier
From:       David Miller <davem () davemloft ! net>
Date:       2013-07-30 23:10:35
Message-ID: 20130730.161035.1646022729333223847.davem () davemloft ! net
[Download RAW message or body]

From: Linus L=FCssing <linus.luessing@web.de>
Date: Thu, 25 Jul 2013 15:56:20 +0200

> +	atomic64_t			multicast_querier_delay_time;

Please don't use an atomic64_t here, it's pointless.

You're only doing set and read operations on it, there's absolutely
nothing atomic about that.

You have to make sure that the top-level operations that use this
new value use an appropriate amount of locking on the higher level
objects.
[prev in list] [next in list] [prev in thread] [next in thread]