[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-bridge
Subject:    Re: [Bridge] [v4 Patch 1/3] netpoll: add generic support for bridge
From:       Cong Wang <amwang () redhat ! com>
Date:       2010-04-28 9:59:03
Message-ID: 4BD806E7.7010806 () redhat ! com
[Download RAW message or body]

Dongdong Deng wrote:
> 
> 
> +             if (ops->ndo_netpoll_cleanup)
> +                                       ops->ndo_netpoll_cleanup(np->dev);
> +             np->dev->npinfo = NULL;
> 
> I think it is good to set np->dev->npinfo to NULL  even though we have
> the netpoll_cleanup opt.
> 

This is redundant, since ->ndo_netpoll_cleanup will set it.

Thanks.
_______________________________________________
Bridge mailing list
Bridge@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/bridge
[prev in list] [next in list] [prev in thread] [next in thread]