[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-bridge
Subject:    Re: [Bridge] Bridge MAC selection
From:       Patrick McHardy <kaber () trash ! net>
Date:       2008-06-12 13:39:39
Message-ID: 4851271B.8080304 () trash ! net
[Download RAW message or body]

Andy Gospodarek wrote:
> On Thu, Jun 12, 2008 at 7:10 AM, Dietmar Maurer <dietmar@proxmox.com> wrote:
>>>>> There any side effects with the following patch?
>>>> Not for you. But if it got changed now, it would surprise the
>>>> existing users (change in ABI behaviour).
>> If there are no other side effects, I wonder whats better:
>>
>> A.) unexpected Network failures due to mac changes
>>
>> B.) surprised users (does anybody depend on such behavour?)
>>
>> I vote for A.)
>>
>> - Dietmar
>>
> 
> You might think A is a better option, but option B is frowned upon.  I
> understand you desire your change the behavior to meet your needs, but
> Patrick's suggestion to add a module parameter to tweak this behavior
> based on a module option is probably better than simply changing the
> existing functionality to meet your needs.

I actually meant a brctl parameter, module parameters suck as
configuration interfaces. But I think the second option is
better, just disable this behaviour automatically when the
address is configured manually.
_______________________________________________
Bridge mailing list
Bridge@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/bridge
[prev in list] [next in list] [prev in thread] [next in thread]