[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-bluetooth
Subject:    [BlueZ v2 13/20] client/player: Fix copy/paste error
From:       Bastien Nocera <hadess () hadess ! net>
Date:       2024-05-10 12:10:23
Message-ID: 20240510121355.3241456-14-hadess () hadess ! net
[Download RAW message or body]

Error: COPY_PASTE_ERROR (CWE-398): [#def95] [important]
bluez-5.75/client/player.c:1846:6: original: "qos->sync_cte_type" looks like the \
original copy. bluez-5.75/client/player.c:1852:6: copy_paste_error: "sync_cte_type" \
in "qos->sync_cte_type" looks like a copy-paste error. \
bluez-5.75/client/player.c:1852:6: remediation: Should it say "mse" instead? 1850|		}
1851|
1852|->		if (qos->sync_cte_type) {
1853|			bt_shell_printf("MSE %u\n", qos->mse);
1854|			g_dbus_dict_append_entry(iter, "MSE", DBUS_TYPE_BYTE,
---
 client/player.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/player.c b/client/player.c
index 6b70e9ed3f9d..7f67425aaf8f 100644
--- a/client/player.c
+++ b/client/player.c
@@ -1849,7 +1849,7 @@ static void append_bcast_qos(DBusMessageIter *iter, struct \
endpoint_config *cfg)  &qos->sync_cte_type);
 	}
 
-	if (qos->sync_cte_type) {
+	if (qos->mse) {
 		bt_shell_printf("MSE %u\n", qos->mse);
 		g_dbus_dict_append_entry(iter, "MSE", DBUS_TYPE_BYTE,
 						&qos->mse);
-- 
2.44.0


[prev in list] [next in list] [prev in thread] [next in thread]