[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-bluetooth
Subject:    [BlueZ v2 10/20] main: Fix memory leaks
From:       Bastien Nocera <hadess () hadess ! net>
Date:       2024-05-10 12:10:20
Message-ID: 20240510121355.3241456-11-hadess () hadess ! net
[Download RAW message or body]

Error: RESOURCE_LEAK (CWE-772): [#def51] [important]
bluez-5.75/src/main.c:451:2: alloc_arg: "parse_config_string" allocates memory that \
is stored into "str". bluez-5.75/src/main.c:454:2: identity_transfer: Passing "str" \
as argument 1 to function "strtol", which sets "endptr" to that argument. \
bluez-5.75/src/main.c:456:3: noescape: Assuming resource "str" is not freed or \
pointed-to as ellipsis argument to "btd_error". bluez-5.75/src/main.c:457:3: \
leaked_storage: Variable "endptr" going out of scope leaks the storage it points to. \
bluez-5.75/src/main.c:457:3: leaked_storage: Variable "str" going out of scope leaks \
the storage it points to. 455|	if (!endptr || *endptr != '\0') {
456|		error("%s.%s = %s is not integer", group, key, str);
457|->		return false;
458|	}
459|

Error: RESOURCE_LEAK (CWE-772): [#def52] [important]
bluez-5.75/src/main.c:451:2: alloc_arg: "parse_config_string" allocates memory that \
is stored into "str". bluez-5.75/src/main.c:454:2: identity_transfer: Passing "str" \
as argument 1 to function "strtol", which sets "endptr" to that argument. \
bluez-5.75/src/main.c:463:3: leaked_storage: Variable "endptr" going out of scope \
leaks the storage it points to. bluez-5.75/src/main.c:463:3: leaked_storage: Variable \
"str" going out of scope leaks the storage it points to. 461|		warn("%s.%s = %zu is \
out of range (< %zu)", group, key, tmp, 462|									min);
463|->		return false;
464|	}
465|

Error: RESOURCE_LEAK (CWE-772): [#def53] [important]
bluez-5.75/src/main.c:451:2: alloc_arg: "parse_config_string" allocates memory that \
is stored into "str". bluez-5.75/src/main.c:454:2: identity_transfer: Passing "str" \
as argument 1 to function "strtol", which sets "endptr" to that argument. \
bluez-5.75/src/main.c:475:2: leaked_storage: Variable "endptr" going out of scope \
leaks the storage it points to. bluez-5.75/src/main.c:475:2: leaked_storage: Variable \
"str" going out of scope leaks the storage it points to. 473|		*val = tmp;
474|
475|->	return true;
476|   }
477|
---
 src/main.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/main.c b/src/main.c
index 23af6781d931..ac840d684f6d 100644
--- a/src/main.c
+++ b/src/main.c
@@ -454,21 +454,25 @@ static bool parse_config_int(GKeyFile *config, const char \
*group,  tmp = strtol(str, &endptr, 0);
 	if (!endptr || *endptr != '\0') {
 		error("%s.%s = %s is not integer", group, key, str);
+		g_free(str);
 		return false;
 	}
 
 	if (tmp < min) {
+		g_free(str);
 		warn("%s.%s = %zu is out of range (< %zu)", group, key, tmp,
 									min);
 		return false;
 	}
 
 	if (tmp > max) {
+		g_free(str);
 		warn("%s.%s = %zu is out of range (> %zu)", group, key, tmp,
 									max);
 		return false;
 	}
 
+	g_free(str);
 	if (val)
 		*val = tmp;
 
-- 
2.44.0


[prev in list] [next in list] [prev in thread] [next in thread]