[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-bluetooth
Subject:    [BlueZ 14/14] shared/vcp: Fix copy/paste error
From:       Bastien Nocera <hadess () hadess ! net>
Date:       2024-05-10 9:11:12
Message-ID: 20240510091814.3172988-15-hadess () hadess ! net
[Download RAW message or body]

Error: COPY_PASTE_ERROR (CWE-398): [#def97] [important]
bluez-5.75/src/shared/vcp.c:2610:16: original: "aics->gain_stting_prop" looks like \
the original copy. bluez-5.75/src/shared/vcp.c:2625:16: copy_paste_error: \
"gain_stting_prop" in "aics->gain_stting_prop" looks like a copy-paste error. \
bluez-5.75/src/shared/vcp.c:2625:16: remediation: Should it say "aud_ip_type" \
instead? 2623|
2624|			aics = vcp_get_aics(vcp);
2625|->			if (!aics || aics->gain_stting_prop)
2626|				return;
2627|
---
 src/shared/vcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/vcp.c b/src/shared/vcp.c
index 7ba54e64adc0..b7e17e448b74 100644
--- a/src/shared/vcp.c
+++ b/src/shared/vcp.c
@@ -2622,7 +2622,7 @@ static void foreach_aics_char(struct gatt_db_attribute *attr, \
void *user_data)  value_handle);
 
 		aics = vcp_get_aics(vcp);
-		if (!aics || aics->gain_stting_prop)
+		if (!aics || aics->aud_ip_type)
 			return;
 
 		aics->aud_ip_type = attr;
-- 
2.44.0


[prev in list] [next in list] [prev in thread] [next in thread]