[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-bluetooth
Subject:    Re: [PATCH BlueZ V2] Mesh: Fix TTL in Config Heartbeat Publication Set
From:       Johan Hedberg <johan.hedberg () gmail ! com>
Date:       2018-03-28 12:48:08
Message-ID: 20180328124808.GA11177 () x1c ! lan
[Download RAW message or body]

Hi Robert,

On Wed, Mar 28, 2018, Robert Lubas wrote:
> The problem is with the TTL field in the message (not valid value is hard
> codded). I proposed a fix by passing ttl into cmd_hb_pub_set (user has to be
> aware of valid values of the TTL as well as of another parameters in this
> function)
> 
> In the 4.4.1.2.15 Heartbeat Publication state (Mesh Profile spec) in the 3rd
> paragraph we can read that if the message is successfully processed (no
> invalid key index error) we should update the Heartbeat Publication state to
> the corresponding field values (defined in Table 4.120). Going to this table
> the Heartbeat Publication TTL state should be updated using message field
> TTL. The message field TTL has to be set according to the 4.2.17.4 Heartbeat
> Publication TTL (0x00-0x7F values are valid).
> 
> In the spec there is nothing about translation to the system settings
> mechanism in case of heartbeat.
> 
> Kindly asking for the review.

I think Brian is on vacation, so there will likely be no response from
him for awhile. The patch looks good to me, and even though we have the
default TTL concept, for testing purposes it's nice to be able to set
the TTL explicitly for the heartbeat configuration.

So, the patch has now been applied upstream. Thanks.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]