[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-bluetooth
Subject:    Re: drivers/bluetooth/dtl1_cs.c:559: bad if statement ?
From:       Marcel Holtmann <marcel () holtmann ! org>
Date:       2016-11-22 21:49:38
Message-ID: 3184A4EA-4F3C-4CBC-AAA1-355CB62B5DE2 () holtmann ! org
[Download RAW message or body]

Hi David,

> drivers/bluetooth/dtl1_cs.c:559:32: warning: logical ‘or' of collectively \
> exhaustive tests is always true [-Wlogical-op] 
> Source code is
> 
> if ((p_dev->resource[1]->end) || (p_dev->resource[1]->end < 8))
> return -ENODEV;
> 
> Maybe better code
> 
> if ((p_dev->resource[1]->end < 0) || (p_dev->resource[1]->end >= 8))
> return -ENODEV;

mind sending a patch?

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]