[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-block
Subject:    Re: [PATCH v2 10/10] blk-throttle: avoid dead code in throtl_hierarchy_can_upgrade
From:       Tejun Heo <tj () kernel ! org>
Date:       2022-11-30 21:36:08
Message-ID: Y4fMyEo0dxPl/Kt1 () slm ! duckdns ! org
[Download RAW message or body]

On Tue, Nov 29, 2022 at 11:01:47AM +0800, Kemeng Shi wrote:
> Function throtl_hierarchy_can_upgrade will always return from while loop,
> so the return outside while loop is never reached. Break the loop when
> we traverse to root as throtl_hierarchy_can_downgrade do to avoid dead
> code.

I don't know why this is an improvement.

-- 
tejun
[prev in list] [next in list] [prev in thread] [next in thread]