[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-block
Subject:    Re: [PATCH v2 34/63] md/raid1: Use the new blk_opf_t type
From:       Song Liu <song () kernel ! org>
Date:       2022-06-30 18:41:12
Message-ID: CAPhsuW5GoFpGbk_MF0PFN0E3E+NwBn_sMNL3bdQ=q3VNBUKpow () mail ! gmail ! com
[Download RAW message or body]

On Wed, Jun 29, 2022 at 4:32 PM Bart Van Assche <bvanassche@acm.org> wrote:
>
> Improve static type checking by using the new blk_opf_t type for
> variables that represent request flags.
>
> Cc: Song Liu <song@kernel.org>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Acked-by: Song Liu <song@kernel.org>

> ---
>  drivers/md/raid1.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index e7cd1d30d68a..8180b57be040 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1220,8 +1220,8 @@ static void raid1_read_request(struct mddev *mddev, struct bio *bio,
>         struct raid1_info *mirror;
>         struct bio *read_bio;
>         struct bitmap *bitmap = mddev->bitmap;
> -       const int op = bio_op(bio);
> -       const unsigned long do_sync = (bio->bi_opf & REQ_SYNC);
> +       const enum req_op op = bio_op(bio);
> +       const blk_opf_t do_sync = bio->bi_opf & REQ_SYNC;
>         int max_sectors;
>         int rdisk;
>         bool r1bio_existed = !!r1_bio;
[prev in list] [next in list] [prev in thread] [next in thread]