[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-block
Subject:    Re: About sbitmap_bitmap_show() and cleared bits (was Re: [PATCH RFC v7 07/12] blk-mq: Add support i
From:       Bart Van Assche <bvanassche () acm ! org>
Date:       2020-06-30 14:55:49
Message-ID: 8dfd5434-674a-5df6-114b-59cfed22588d () acm ! org
[Download RAW message or body]

On 2020-06-29 08:32, John Garry wrote:
> I noticed that sbitmap_bitmap_show() only shows set bits and does not
> consider cleared bits. Is that the proper thing to do?
> 
> I ask, as from trying to support sbitmap_bitmap_show() for hostwide
> shared tags feature, we currently use blk_mq_queue_tag_busy_iter() to
> find active requests (and associated tags/bits) for a particular hctx.
> So, AFAICT, would give a change in behavior for sbitmap_bitmap_show(),
> in that it would effectively show set and not cleared bits.
> 
> Any thoughts on this?

Probably this is something that got overlooked when the cleared bits
were introduced? See e.g. 8c2def893afc ("sbitmap: fix
sbitmap_for_each_set()").

Bart.

[prev in list] [next in list] [prev in thread] [next in thread]