[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-bcache
Subject:    Re: [PATCH] drivers: md: Mark the function btree_insert_fn() as static in btree.c
From:       Josh Triplett <josh () joshtriplett ! org>
Date:       2013-12-14 20:44:15
Message-ID: 20131214204414.GK17601 () leaf
[Download RAW message or body]

On Sat, Dec 14, 2013 at 06:29:29PM +0530, Rashika Kheria wrote:
> This patch marks the function btree_insert_fn() as static in
> bcache/btree.c because it is not used outside this file.
> 
> Thus, it also eliminates the following warning in bcache/btree.c:
> drivers/md/bcache/btree.c:2220:5: warning: no previous prototype for \
> ‘btree_insert_fn' [-Wmissing-prototypes] 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> drivers/md/bcache/btree.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 5e2765a..dc6e2be 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -2217,7 +2217,7 @@ struct btree_insert_op {
> 	struct bkey	*replace_key;
> };
> 
> -int btree_insert_fn(struct btree_op *b_op, struct btree *b)
> +static int btree_insert_fn(struct btree_op *b_op, struct btree *b)
> {
> 	struct btree_insert_op *op = container_of(b_op,
> 					struct btree_insert_op, op);
> -- 
> 1.7.9.5
> 


[prev in list] [next in list] [prev in thread] [next in thread]