[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-backports
Subject:    Re: [PATCH 08/10] patches: remove .coredump from struct driver for kernel < 4.16
From:       Hauke Mehrtens <hauke () hauke-m ! de>
Date:       2018-09-24 20:20:03
Message-ID: 77307628-5584-e5d1-255e-b730c201dc91 () hauke-m ! de
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On 09/24/2018 10:36 AM, Johannes Berg wrote:
> On Sun, 2018-09-23 at 19:45 +0200, Hauke Mehrtens wrote:
>> Kernel 4.16 added a new .coredump member to the driver structure which
>> can be implemented by drivers. Remove this member on older kernel
>> versions as they do not support this feature.
> 
> Note that this isn't sufficient.
> 
> On 4.16, the return value was int, now it's void. I'll change this patch
> to be for < 4.17, but if somebody wants to submit an spatch to fix up
> the difference that would work too.
> 
> johannes
> 
Thanks for fixing this, I didn't noticed that this changed between 4.16
and 4.17. I think it is ok to only provide this on kernel >= 4.17, this
is an not essential feature and 4.16 is not a long term kernel.

Hauke


["signature.asc" (application/pgp-signature)]
--
To unsubscribe from this list: send the line "unsubscribe backports" in

[prev in list] [next in list] [prev in thread] [next in thread]