[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-backports
Subject:    Re: [PATCH 13/14] backport: convert int led activate op to void when needed
From:       Luca Coelho <luca () coelho ! fi>
Date:       2018-09-24 9:24:03
Message-ID: 948ce87ddf7b135e98506a2f0f2d56d9ccb43228.camel () coelho ! fi
[Download RAW message or body]

On Sun, 2018-09-23 at 14:30 +0200, Hauke Mehrtens wrote:
> On 09/20/2018 01:28 PM, Luca Coelho wrote:
> > From: Luca Coelho <luciano.coelho@intel.com>
> > 
> > In kernel v4.19-rc1, the activate op in struct led_trigger, changed
> > from void to int.  To solve this, add a semantic patch to insert a
> > wrapper function that returns void and calls the function that
> > returns
> > int.
> > 
> > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> > ---
> >  patches/led_activate.cocci | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >  create mode 100644 patches/led_activate.cocci
> > 
> > diff --git a/patches/led_activate.cocci
> > b/patches/led_activate.cocci
> > new file mode 100644
> > index 000000000000..df8211d29462
> > --- /dev/null
> > +++ b/patches/led_activate.cocci
> > @@ -0,0 +1,24 @@
> > +@act@
> > +identifier activate_fn, p;
> > +identifier m =~ "rx_led|tx_led|assoc_led|radio_led|tpt_led";
> > +fresh identifier activate_fn_wrap = "bp_" ## activate_fn;
> > +@@
> > +<...
> > ++#if LINUX_VERSION_IS_GEQ(4,19,0)
> > +p->m.activate = activate_fn;
> > ++#else
> > ++p->m.activate = activate_fn_wrap;
> > ++#endif
> > +...>
> 
> Please use <+--- ---+> here it improves the speed by some magnitudes.

Thanks for pointing out.  I remember the discussion about this with
Julia.  Johannes already fixed this in-place before applying my patch.

--
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe backports" in
[prev in list] [next in list] [prev in thread] [next in thread]