[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-backports
Subject:    Re: [PATCH 03/14] patches: Use old parameter type for DEFINE_TIMER
From:       Johannes Berg <johannes () sipsolutions ! net>
Date:       2018-03-21 7:59:25
Message-ID: 1521619165.2645.11.camel () sipsolutions ! net
[Download RAW message or body]

On Sun, 2018-03-04 at 23:57 +0100, Hauke Mehrtens wrote:
> Use the unsigned long parameters on kernel versions < 4.15 for the
> DEFINE_TIMER callback. This was changed in Linux mainline commit
> 24ed960abf1d ("treewide: Switch DEFINE_TIMER callbacks to struct
> timer_list *")

But before this, we had a macro that could deal with both ways - why
can't we backport using a similar macro, rather than doing a patch?

If we have

 static void at76_ledtrig_tx_timerfunc(struct timer_list *unused);

then we should be able to

#define DEFINE_TIMER(x, y) ... (cast)(y)

or something, no?

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
[prev in list] [next in list] [prev in thread] [next in thread]