[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-backports
Subject:    Re: [PATCH 12/21] compat: avoid usage of kvzalloc() in rhashtable.c
From:       Johannes Berg <johannes () sipsolutions ! net>
Date:       2017-09-08 9:25:02
Message-ID: 1504862702.6177.17.camel () sipsolutions ! net
[Download RAW message or body]

On Thu, 2017-09-07 at 00:12 +0200, Hauke Mehrtens wrote:
> On 09/06/2017 05:05 PM, Johannes Berg wrote:
> > On Tue, 2017-08-22 at 00:28 +0200, Hauke Mehrtens wrote:
> > > This reverts commit 12e8fd6fd3802 ("lib/rhashtable.c: use
> > > kvzalloc()
> > > in
> > > bucket_table_alloc() when possible") from upstream kernel.
> > > Kernel versions older that 4.12 do not have kvzalloc() try to
> > > avoid
> > > the
> > > usage of this.
> > 
> > Can't we backport these? There was a patch from AceLan Kao to do so
> > in
> > a pretty simple fashion, but that should still be better than a
> > patch?
> > 
> > johannes
> 
> Hi,
> 
> I think AceLan Kao's patch misses the implementation of
> kvmalloc_node().
> We can implement this for node == NUMA_NO_NODE by using __vmalloc()
> instead of __vmalloc_node_flags_caller() which should be fine.

Sounds reasonable to me.

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
[prev in list] [next in list] [prev in thread] [next in thread]