[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-audit
Subject:    [PATCH] fix audit oops with invalid operator
From:       Amy Griffis <amy.griffis () hp ! com>
Date:       2006-08-01 21:52:26
Message-ID: 20060801215226.GA18242 () dill ! zko ! hp ! com
[Download RAW message or body]

Michael C Thompson wrote:  [Tue Aug 01 2006, 02:36:36PM EDT]
> The trigger for this oops is:
> # auditctl -a exit,always -S pread64 -F 'inode<1'

Setting the err value will fix it.

Signed-off-by: Amy Griffis <amy.griffis@hp.com>

diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index 7322f34..6a9a5c5 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -442,6 +442,7 @@ static struct audit_entry *audit_rule_to
 		case AUDIT_EQUAL:
 			break;
 		default:
+			err = -EINVAL;
 			goto exit_free;
 		}
 	}
@@ -579,6 +580,7 @@ static struct audit_entry *audit_data_to
 		case AUDIT_EQUAL:
 			break;
 		default:
+			err = -EINVAL;
 			goto exit_free;
 		}
 	}

[prev in list] [next in list] [prev in thread] [next in thread]