[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-arm-kernel
Subject:    Re: [PATCH 1/3] dma: mv_xor: take channel spinlock in mv_xor_status()
From:       Dan Williams <dan.j.williams () intel ! com>
Date:       2013-12-31 22:48:30
Message-ID: CAPcyv4hRP3o0=LTByvp8mg3x2iBo5fQ_pwmTzXnjHs4hxPXvkA () mail ! gmail ! com
[Download RAW message or body]

On Fri, Dec 27, 2013 at 3:38 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> The mv_xor_status() function accesses the mv_xor_chan structure, but
> was not taking the corresponding spinlock. This patch fixes this
> problem.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  drivers/dma/mv_xor.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
> index 53fb0c8..526ab27 100644
> --- a/drivers/dma/mv_xor.c
> +++ b/drivers/dma/mv_xor.c
> @@ -701,14 +701,20 @@ static enum dma_status mv_xor_status(struct dma_chan *chan,
>         struct mv_xor_chan *mv_chan = to_mv_xor_chan(chan);
>         enum dma_status ret;
>
> +       spin_lock_bh(&mv_chan->lock);
> +
>         ret = dma_cookie_status(chan, cookie, txstate);
>         if (ret == DMA_COMPLETE) {
>                 mv_xor_clean_completed_slots(mv_chan);

I think you can just delete this call to
mv_xor_clean_completed_slots().  The fact that the descriptors are
complete means that __mv_xor_slot_cleanup ran, and if that is the case
there should be nothing to cleanup.

--
Dan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[prev in list] [next in list] [prev in thread] [next in thread]