[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-arm-kernel
Subject:    Re: [PATCH] RFC: IOP32X gpio/gpiolib support
From:       "Dan Williams" <dan.j.williams () intel ! com>
Date:       2008-03-31 22:38:44
Message-ID: e9c3a7c20803311538l4d2b5003oc0d4509cbb1717e () mail ! gmail ! com
[Download RAW message or body]

On Mon, Mar 31, 2008 at 3:11 PM, Rtp Arnaud Patard
<arnaud.patard@rtp-net.org> wrote:
>
> "Dan Williams" <dan.j.williams@intel.com> writes:
>
>  > On Mon, Mar 31, 2008 at 1:04 PM, Rtp Arnaud Patard
>  > <arnaud.patard@rtp-net.org> wrote:
>  >> Hi,
>  >>
>  >>  This patch adds GPIO/GPIOLIB support to IOP32X SoCs. It has been tested
>  >>  on my SS4000e (80219 based) with a gpio expander and the SoC gpios.
>  >>
>  >>
>  >>  Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>  >>  ---
>  >
>  > The GPIO implementation on iop33x is nearly identical (just at a
>  > different address).  So, this support need not be iop32x specific,
>  > i.e. it can all go in arch/arm/plat-iop/gpio.c and
>  > include/asm-arm/hardware/iop3xx.h.
>
>  ok. Will change from iop32x to iop3xx.
>  The gpio framework ask for a include/asm/arch/gpio.h. If I put all stuff
>  that it's in include/asm-arm/arch-iop32x/gpio.h into
>  include/asm-arm/hardware/iop3xx.h and provide a gpio.h header which will
>  include it, will you have any objection ?
>

No objection, although looking at it again I would say put this into a
new include/asm-arm/hardware/iop3xx-gpio.h header file.

--
Dan

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php
[prev in list] [next in list] [prev in thread] [next in thread]