[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-arm-kernel
Subject:    [patch 2.6.22-rc3] SPI -- Freescale iMX SPI controller driver
From:       "Andrea Paterniani" <a.paterniani () swapp-eng ! it>
Date:       2007-05-31 10:33:17
Message-ID: FLEPLOLKEPNLMHOILNHPKEHEDHAA.a.paterniani () swapp-eng ! it
[Download RAW message or body]

Subject: [patch-2.6.22-rc3-spi_imx] arm: SPI controller driver for Freescale iMX
From: Andrea Paterniani <a.paterniani@swapp-eng.it>

Kernel version: linux-2.6.22-rc3.
This is patch fixes 2 bugs:
> SPI_DMA_RHDMA bad value.
> Missing return value in setup() function (lost passing from
patch-2.6.20-rc4-spi_imx to patch-2.6.20-rc6-spi_imx).

Signed-off-by: Andrea Paterniani <a.paterniani@swapp-eng.it>
---

diff -uprN -X linux-2.6.22-rc3/Documentation/dontdiff linux-2.6.22-rc3/drivers/spi/spi_imx.c
linux-2.6.22-rc3-spi_imx/drivers/spi/spi_imx.c
--- linux-2.6.22-rc3/drivers/spi/spi_imx.c	2007-04-26 05:08:32.000000000 +0200
+++ linux-2.6.22-rc3-spi_imx/drivers/spi/spi_imx.c	2007-05-31 12:09:07.000000000 +0200
@@ -121,7 +121,7 @@
 							32.768 KHz Clock */

 /* SPI DMA Register Bit Fields & Masks */
-#define SPI_DMA_RHDMA	(0xF << 4)	/* RXFIFO Half Status */
+#define SPI_DMA_RHDMA	(0x1 << 4)	/* RXFIFO Half Status */
 #define SPI_DMA_RFDMA	(0x1 << 5)      /* RXFIFO Full Status */
 #define SPI_DMA_TEDMA	(0x1 << 6)      /* TXFIFO Empty Status */
 #define SPI_DMA_THDMA	(0x1 << 7)      /* TXFIFO Half Status */
@@ -1355,6 +1355,7 @@ static int setup(struct spi_device *spi)
 		spi->bits_per_word,
 		spi_speed_hz(SPI_CONTROL_DATARATE_MIN),
 		spi->max_speed_hz);
+	return status;

 err_first_setup:
 	kfree(chip);


-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php
[prev in list] [next in list] [prev in thread] [next in thread]