[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-arm-kernel
Subject:    Re: Suspend/resume broken in 2.6.13 for PXA
From:       Dimitry Andric <dimitry () andric ! com>
Date:       2005-11-30 12:38:47
Message-ID: 438D9D57.8020609 () andric ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Paul Sokolovsky wrote:
>   Currently suggested look-for's give nothing: cpu_init() is called
> from PXA immediately after waking from suspend (not calling it doesn't
> change hang behavior), and cpuinit() is not marked as __init (read abou=
t
> that in another mail message/patch).

cpu_init() calls dump_cpu_info(), which IS marked __init, and this
will cause problems, of course.  Our simple fix was to remove the
__init from dump_cpu_info.  This might be a bit ugly, but it works. :)

Of course the proper fix is to only call dump_cpu_info() from
cpu_init() at boot time, or split cpu_init() in a cpu_init_at_boot and
cpu_init_at_resume.



["signature.asc" (application/pgp-signature)]

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php

[prev in list] [next in list] [prev in thread] [next in thread]