[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-arm-kernel
Subject:    Re: lh7a40x_udc: flaky (at best)
From:       Oliver Nittka <nittka () esem ! com>
Date:       2005-06-30 7:19:35
Message-ID: 42C39D07.6040001 () esem ! com
[Download RAW message or body]



John Bx schrieb:

> if you look around line 1837 in the USB_REQ_GET_STATUS case it
> incorrectly let certain packets ment for higher protocol  levels into
> the baseline driver section as a get status msg.

i've got the following at line 1759:

        case USB_REQ_GET_STATUS:{
                        if (lh7a40x_handle_get_status(dev, &ctrl) == 0)
                                return;

maybe this is what you meant?


i've also found some suspicious code in lh7a40x_handle_get_status() at
line 1638:

        if (reqtype == USB_RECIP_INTERFACE) {
                /* This is not supported.
                 * And according to the USB spec, this one does nothing..
                 * Just return 0
                 */
                DEBUG_SETUP("GET_STATUS: USB_RECIP_INTERFACE\n");
        } else if (reqtype == USB_RECIP_DEVICE) {


shouldn't it return 0 when the comment says "return 0"? or is it meant
to fall through the "else if"s?

> if this hasnt been fixed i can try and find the patch again...

that would be very kind!

> John

  --o
-- 
Oliver Nittka
ESEM Grünau GmbH & Co. KG
Dornierstraße 6, 88677 Markdorf/Germany
phone: +49 7544 9583-25, fax: +49 7544 9583-60

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php

[prev in list] [next in list] [prev in thread] [next in thread]