[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-arm-kernel
Subject:    Re: [PATCH] 0/7 PXA framebuffer driver
From:       Russell King - ARM Linux <linux () arm ! linux ! org ! uk>
Date:       2003-09-25 22:30:59
[Download RAW message or body]

On Thu, Sep 25, 2003 at 12:21:36PM +0100, Ian Campbell wrote:
> I will follow this message with a series of patches to the PXA25x
> framebuffer driver. I wasn't sure whether one big mail/patch or 7
> smaller ones were appropriate, so I hope this is OK (my apologies if
> not).

I've had a quick scan through them.  You used is the preferred format -
patches split up into clearly defined purposes.  It makes review by anyone
really easy.

> In the future I'm thinking of moving the board configurations into
> structures in the .c file (same as sa1100fb.c). I've seen some talk on
> list about moving them somewhere else (I can't remember where) -- that
> would be cool too -- I mostly want to get away from the current #define
> system.

Ideally into arch/arm/mach-*/*.c for 2.6 and passing a well-defined
structure via the platform devices platform_data element.

> More importantly I'd like to support setting LCCR* and other parameters
> on the module command line -- I need this because our development kit is
> sold with a particular TFT panel in it, but customers always want some
> other TFT or STN panel, I'd like to avoid them needing to recompile the
> kernel if I can.

I think this gets fairly messy, or you end up with bland "LCCR0=foo"
and the customer needs to work out the right values, and possibly set
some bits that the driver isn't expecting... or the customer wonders
why he can't set the pixel clock rate that way... or whatever.


As far as 2.6 goes, its easier for me to apply patches via the patch
system than via email, so could you submit them via the patch system
(you can do that by sending a set of emails as described on the web
site in much the same way that you've sent these patches to the lists.)

-------------------------------------------------------------------
Subscription options: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ/Etiquette:       http://www.arm.linux.org.uk/armlinux/mailinglists.php

[prev in list] [next in list] [prev in thread] [next in thread]