[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-arm-kernel
Subject:    linux-2.4.70-rmk1-pxa1: fix warning drivers/mtd/maps/pxa.c
From:       Holger Schurig <holgerschurig () gmx ! de>
Date:       2003-07-12 12:19:59
[Download RAW message or body]

void functions() should not return values.

In "make xconfig", the help texts and the config variable refer to "CFI Flash 
device mapped on XScale PXA2xx". But the code inside claimed "Lubbock flash". 
I changed this to some more generic text.

--- linux-2.5.70/drivers/mtd/maps/pxa.c~pxa1-fixes
+++ linux-2.5.70/drivers/mtd/maps/pxa.c
@@ -62,7 +62,7 @@
 }
 
 static struct map_info mtd_pxa_map = {
-	name: "Lubbock flash",
+	name: "Flash",
 	size: WINDOW_SIZE,
 	read8:		mtd_pxa_read8,
 	read16:		mtd_pxa_read16,
@@ -169,7 +169,7 @@
 	}
 	if (mtd_pxa_map.map_priv_1)
 		iounmap((void *)mtd_pxa_map.map_priv_1);
-	return 0;
+	return;
 }
 
 module_init(init_mtd_pxa);


-------------------------------------------------------------------
Subscription options: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ/Etiquette:       http://www.arm.linux.org.uk/armlinux/mailinglists.php

[prev in list] [next in list] [prev in thread] [next in thread]