[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-arm-kernel
Subject:    Suggestion on naming pxafb_mach_info records
From:       Holger Schurig <h.schurig () mn-logistik ! de>
Date:       2002-06-27 6:46:54
[Download RAW message or body]

Currently we have this this:



static struct pxafb_mach_info lubbock_info __initdata = {
...
static struct pxafb_mach_info idp_info __initdata = {
...
static struct pxafb_mach_info ramses_info __initdata
...

and later the in the code

static struct pxafb_mach_info * __init
pxafb_get_machine_info(struct pxafb_info *fbi)
{
        struct pxafb_mach_info *inf = NULL;

        if (machine_is_lubbock()) {
                inf = &lubbock_info;
        } else if (machine_is_pxa_idp()) {
                inf = &idp_info;
        } else if (machine_is_ramses()) {
                inf = &ramses_info;
        }
        return inf;
}




I suggest to change this to (the names of the LCD panels are freely 
invented, with the exception of the Kyocera Display):



static struct pxafb_mach_info epson12345_info __initdata = {
...
static struct pxafb_mach_info vender3456_info __initdata = {
...
static struct pxafb_mach_info kyocera_kcs038aa1aa_info __initdata
...

static struct pxafb_mach_info * __init
pxafb_get_machine_info(struct pxafb_info *fbi)
{
        struct pxafb_mach_info *inf = NULL;

        if (machine_is_lubbock()) {
                inf = &epson12345_info;
        } else if (machine_is_pxa_idp()) {
                inf = &vender3456_info;
        } else if (machine_is_ramses()) {
                inf = &kyocera_kcs038aa1aa_info;
        }
        return inf;
}

-- 
MN-Logistik GmbH         http://www.mn-logistik.de
Holger Schurig           Network Administrator
Dieselstr. 18
61191 Rosbach v.d.Höhe
Tel: 06003/9141-0        Fax: 06003/9141-49


-------------------------------------------------------------------
Subscription options: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ/Etiquette:       http://www.arm.linux.org.uk/armlinux/mailinglists.php

[prev in list] [next in list] [prev in thread] [next in thread]