[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-arm-kernel
Subject:    AW: problem with mcp-core.c in 2.4.17-rmk5
From:       Messerer Juergen <juergen.messerer () siemens ! com>
Date:       2002-02-27 8:34:27
[Download RAW message or body]

This is the wright solution. I have told  Russell about that bug wright
after the release of 2.4.17-rmk5

if (mcp->owner) 
{ 
   .....
}


Best regards
Juergen 


> -----Ursprüngliche Nachricht-----
> Von:	Russ Dill [SMTP:Russ.Dill@asu.edu]
> Gesendet am:	Mittwoch, 27. Februar 2002 03:46
> An:	Brad Parker
> Cc:	linux-arm-kernel@lists.arm.linux.org.uk
> Betreff:	Re: problem with mcp-core.c in 2.4.17-rmk5
> 
> On Tue, 2002-02-26 at 19:02, Brad Parker wrote:
> > 
> > Russ Dill wrote:
> > >
> > >
> > >int mcp_register(struct mcp *mcp)
> > >{
> > >        if (mcp_if)
> > >                return -EBUSY;
> > >        __MOD_INC_USE_COUNT(mcp->owner);
> > >        mcp_if = mcp;
> > >        return 0;
> > >}
> > >
> > >causes an oops if mcp-sal100.c is built into the kernel (mcp->owner is
> > >NULL)
> > 
> > This is true in 2.4.17-rmk5 also.  I fixed it but wrapping the __MOD...
> > in '#ifdef MODULE'
> 
> thats the version I said...I don't think the #ifdef MODULE wrapping is
> the correct solution, since mcp-core may be built into the kernel, but
> mcp-sa1100 a module. A more correct solution would probably be to wrap
> it in an if (mcp->owner) { }. I was just trying to notify rmk, since it
> seems to be his code
> 
> 
> _______________________________________________
> http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
> http://www.arm.linux.org.uk/armlinux/mailinglists.php
> Please visit the above addresses for information on this list.

_______________________________________________
http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
http://www.arm.linux.org.uk/armlinux/mailinglists.php
Please visit the above addresses for information on this list.

[prev in list] [next in list] [prev in thread] [next in thread]