[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-arch
Subject:    Re: [PATCH] WorkStruct: Fix S390 driver workstruct usage
From:       Martin Schwidefsky <schwidefsky () de ! ibm ! com>
Date:       2006-12-09 19:51:09
Message-ID: 1165693869.17186.5.camel () localhost
[Download RAW message or body]

On Fri, 2006-12-08 at 17:33 +0000, Al Viro wrote:
> I don't think it's a real fix.
> 
> a) what protects tty from disappearing?

Nothing..

> b) why the hell do we need that schedule_work() at all?  handle_sysrq() is
> supposed to be safe to use from irq handler; when needed it does arrange for
> delayed execution itself.

Fritz probably did that because earlier versions of handle_sysrq() could
not be called in interrupt context. ctrlchar.c is rather old, the first
checkin I can see is from 2001/01/18. 

> So how about we simply call handle_sysrq() there and be done with that?
> Martin?

If it works that is fine with me. Another simplification. I take a look
at it next week.

-- 
blue skies,
  Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.


-
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]