[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-api
Subject:    Re: [PATCH v1 04/14] futex: Validate futex value against futex size
From:       Thomas Gleixner <tglx () linutronix ! de>
Date:       2023-07-31 17:12:46
Message-ID: 87y1iwm2cx.ffs () tglx
[Download RAW message or body]

On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote:
> +static inline bool futex_validate_input(unsigned int flags, u64 val)
> +{
> +	int bits = 8 * futex_size(flags);
> +	if (bits < 64 && (val >> bits))

New line between declaration and code. 

> +		return false;
> +	return true;
> +}

Other than that::

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
[prev in list] [next in list] [prev in thread] [next in thread]