[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-api
Subject:    Re: [PATCH 1/3] v4l: Add Qualcomm custom compressed pixel formats
From:       Nicolas Dufresne <nicolas () ndufresne ! ca>
Date:       2021-04-29 19:10:36
Message-ID: d54b1bb7956e1e3bea47fde1216084c7f2eae87e.camel () ndufresne ! ca
[Download RAW message or body]

Le jeudi 29 avril 2021 à 13:58 +0300, Stanimir Varbanov a écrit :
> Here we add custom Qualcomm raw compressed pixel formats. They are
> used in Qualcomm SoCs to optimaize the interconnect bandwidth.

Wasn't reviewing, just skimming the lists, but s/optimaize/optimize/

> 
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> ---
> .../userspace-api/media/v4l/pixfmt-reserved.rst      | 12 ++++++++++++
> drivers/media/v4l2-core/v4l2-ioctl.c                 |  2 ++
> include/uapi/linux/videodev2.h                       |  2 ++
> 3 files changed, 16 insertions(+)
> 
> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst \
> b/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst index \
>                 0b879c0da713..30b9cef4cbf0 100644
> --- a/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst
> +++ b/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst
> @@ -260,6 +260,18 @@ please make a proposal on the linux-media mailing list.
> 	of tiles, resulting in 32-aligned resolutions for the luminance plane
> 	and 16-aligned resolutions for the chrominance plane (with 2x2
> 	subsampling).
> +    * .. _V4L2-PIX-FMT-QC8C:
> +
> +      - ``V4L2_PIX_FMT_QC8C``
> +      - 'QC8C'
> +      - Compressed Macro-tile 8Bit YUV420 format used by Qualcomm platforms.
> +	The compression is lossless. It contains four planes.

Would be nice to document if the bytesperline is meaningful or not. Basically,
what information need to be carried to other drivers ?

> +    * .. _V4L2-PIX-FMT-QC10C:
> +
> +      - ``V4L2_PIX_FMT_QC10C``
> +      - 'QC10C'
> +      - Compressed Macro-tile 10Bit YUV420 format used by Qualcomm platforms.
> +	The compression is lossless. It contains four planes.
> 
> 
> 
> 
> 
> 
> 
> 
> .. raw:: latex
> 
> 
> 
> 
> 
> 
> 
> 
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c \
> b/drivers/media/v4l2-core/v4l2-ioctl.c index 6a5d1c6d11d6..33ee12b97aa0 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1455,6 +1455,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> 		case V4L2_PIX_FMT_S5C_UYVY_JPG:	descr = "S5C73MX interleaved UYVY/JPEG"; break;
> 		case V4L2_PIX_FMT_MT21C:	descr = "Mediatek Compressed Format"; break;
> 		case V4L2_PIX_FMT_SUNXI_TILED_NV12: descr = "Sunxi Tiled NV12 Format"; break;
> +		case V4L2_PIX_FMT_QC8C:		descr = "QCOM Compressed 8bit Format"; break;
> +		case V4L2_PIX_FMT_QC10C:	descr = "QCOM Compressed 10bit Format"; break;
> 		default:
> 			if (fmt->description[0])
> 				return;
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 311a01cc5775..c57628a16cf4 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -737,6 +737,8 @@ struct v4l2_pix_format {
> #define V4L2_PIX_FMT_SUNXI_TILED_NV12 v4l2_fourcc('S', 'T', '1', '2') /* Sunxi \
> Tiled NV12 Format */ #define V4L2_PIX_FMT_CNF4     v4l2_fourcc('C', 'N', 'F', '4') \
> /* Intel 4-bit packed depth confidence information */ #define V4L2_PIX_FMT_HI240    \
> v4l2_fourcc('H', 'I', '2', '4') /* BTTV 8-bit dithered RGB */ +#define \
> V4L2_PIX_FMT_QC8C     v4l2_fourcc('Q', '0', '8', 'C') /* Qualcomm 8-bit compressed \
> */ +#define V4L2_PIX_FMT_QC10C    v4l2_fourcc('Q', '1', '0', 'C') /* Qualcomm \
> 10-bit compresed */ 
> 
> 
> 
> 
> 
> 
> 
> /* 10bit raw bayer packed, 32 bytes for every 25 pixels, last LSB 6 bits unused */
> #define V4L2_PIX_FMT_IPU3_SBGGR10	v4l2_fourcc('i', 'p', '3', 'b') /* IPU3 packed \
> 10-bit BGGR bayer */


[prev in list] [next in list] [prev in thread] [next in thread]