[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-api
Subject:    Re: [PATCH v2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy
From:       Greg KH <gregkh () linuxfoundation ! org>
Date:       2017-04-27 11:55:54
Message-ID: 20170427115554.GA22360 () kroah ! com
[Download RAW message or body]

On Thu, Apr 27, 2017 at 01:57:16PM +0300, Kirill Tkhai wrote:
> --- a/include/uapi/linux/nsfs.h
> +++ b/include/uapi/linux/nsfs.h
> @@ -14,5 +14,12 @@
>  #define NS_GET_NSTYPE		_IO(NSIO, 0x3)
>  /* Get owner UID (in the caller's user namespace) for a user namespace */
>  #define NS_GET_OWNER_UID	_IO(NSIO, 0x4)
> +/* Set a vector of ns_last_pid for a pid namespace stack */
> +#define NS_SET_LAST_PID_VEC	_IO(NSIO, 0x5)
> +
> +struct ns_ioc_pid_vec {
> +	unsigned int nr;

Please make this an explicit type, variables that cross the user/kernel
boundry should be using __u32 and friends, not vague things like "int".

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]